[
https://issues.apache.org/jira/browse/HDFS-17073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741276#comment-17741276
]
ASF GitHub Bot commented on HDFS-17073:
---------------------------------------
haiyang1987 commented on code in PR #5817:
URL: https://github.com/apache/hadoop/pull/5817#discussion_r1257234652
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java:
##########
@@ -493,7 +493,8 @@ void compute() throws IOException {
checksumBlock(block, idx, liveBlkInfo.getToken(),
liveBlkInfo.getDn());
} catch (IOException ioe) {
- LOG.warn("Exception while reading checksum", ioe);
+ LOG.warn("Exception while reading checksum for block {} at index
{} " +
+ "in blockGroup {}", block, idx, blockGroup, ioe);
Review Comment:
Hi @xinglin thanks help review it.
thanks for the suggestion, I'll update later
> Enhance the warning message output for
> BlockGroupNonStripedChecksumComputer#compute
> -----------------------------------------------------------------------------------
>
> Key: HDFS-17073
> URL: https://issues.apache.org/jira/browse/HDFS-17073
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> Consider improving the log output of the warning messages generated by
> BlockGroupNonStripedChecksumComputer when calling checksumBlock, to make it
> easier to locate the block information where an exception occurs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
