[ https://issues.apache.org/jira/browse/HDFS-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742321#comment-17742321 ]
ASF GitHub Bot commented on HDFS-17074: --------------------------------------- hfutatzhanghb commented on PR #5822: URL: https://github.com/apache/hadoop/pull/5822#issuecomment-1632098271 @ayushtkn @zhangshuyan0 Hi, sir. Could you please help me review this simple modification when you have free time? Thanx a lot. > Remove incorrect comment in TestRedudantBlocks#setup > ---------------------------------------------------- > > Key: HDFS-17074 > URL: https://issues.apache.org/jira/browse/HDFS-17074 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 3.4.0 > Reporter: farmmamba > Assignee: farmmamba > Priority: Trivial > Labels: pull-request-available > > In TestRedudantBlocks#setup(), The below comment is incorrect. > {code:java} > // disable block recovery > conf.setInt(DFSConfigKeys.DFS_NAMENODE_REDUNDANCY_INTERVAL_SECONDS_KEY, 1); > conf.setInt(DFSConfigKeys.DFS_HEARTBEAT_INTERVAL_KEY, 1);{code} > We should delete this comment. > The correct usage is in TestAddOverReplicatedStripedBlocks#setup() > {code:java} > // disable block recovery > conf.setInt(DFSConfigKeys.DFS_NAMENODE_REPLICATION_MAX_STREAMS_KEY, 0); > conf.setInt(DFSConfigKeys.DFS_NAMENODE_REDUNDANCY_INTERVAL_SECONDS_KEY, 1); > conf.setInt(DFSConfigKeys.DFS_HEARTBEAT_INTERVAL_KEY, 1); {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org