[ 
https://issues.apache.org/jira/browse/HDFS-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742379#comment-17742379
 ] 

ASF GitHub Bot commented on HDFS-17081:
---------------------------------------

haiyang1987 opened a new pull request, #5833:
URL: https://github.com/apache/hadoop/pull/5833

   ### Description of PR
   
   https://issues.apache.org/jira/browse/HDFS-17081
   
   Append ec file check if a block is replicated to at least the minimum 
replication need consider ec block.
   
   currently only the minimum replication of the replica is considered, the 
code is as follows:
   
   /**
   ```
      * Check if a block is replicated to at least the minimum replication.
      */
     public boolean isSufficientlyReplicated(BlockInfo b) {
       // Compare against the lesser of the minReplication and number of live 
DNs.
       final int liveReplicas = countNodes(b).liveReplicas();
       if (liveReplicas >= minReplication) {
         return true;
       }
       // getNumLiveDataNodes() is very expensive and we minimize its use by
       // comparing with minReplication first.
       return liveReplicas >= getDatanodeManager().getNumLiveDataNodes();
     }
   ```




> Append ec file check if a block is replicated to at least the minimum 
> replication need consider striped block
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17081
>                 URL: https://issues.apache.org/jira/browse/HDFS-17081
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haiyang Hu
>            Assignee: Haiyang Hu
>            Priority: Major
>
> Append ec file check if a block is replicated to at least the minimum 
> replication need consider ec block.
> currently only the minimum replication of the replica is considered, the code 
> is as follows:
> {code:java}
> /**
>    * Check if a block is replicated to at least the minimum replication.
>    */
>   public boolean isSufficientlyReplicated(BlockInfo b) {
>     // Compare against the lesser of the minReplication and number of live 
> DNs.
>     final int liveReplicas = countNodes(b).liveReplicas();
>     if (liveReplicas >= minReplication) {
>       return true;
>     }
>     // getNumLiveDataNodes() is very expensive and we minimize its use by
>     // comparing with minReplication first.
>     return liveReplicas >= getDatanodeManager().getNumLiveDataNodes();
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to