[
https://issues.apache.org/jira/browse/HDFS-17111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746554#comment-17746554
]
ASF GitHub Bot commented on HDFS-17111:
---------------------------------------
xinglin commented on code in PR #5860:
URL: https://github.com/apache/hadoop/pull/5860#discussion_r1272550379
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -264,7 +264,7 @@ public HdfsFileStatus create(String src, FsPermission
masked,
String clientName, EnumSetWritable<CreateFlag> flag,
boolean createParent, short replication, long blockSize,
CryptoProtocolVersion[] supportedVersions, String ecPolicyName,
- String storagePolicy)
+ String storagePolicyName)
Review Comment:
I don't have context regarding how this practice came into play. In my
opinion, we should be open to include such trivial improvements.
- It is clear from retrospective that this is a trivial rename improvement.
There is no confusion that such a trivial change would cause.
Otherwise, we would have to create a separate PR to get this trivial change
in, which would
- Add more work to the PR author
- Add more review load.
Even worse, given such a trivial improvement, people may simply don't want
to do it, as a separate PR.
> RBF: Optimize msync to only call nameservices that have observer reads
> enabled.
> -------------------------------------------------------------------------------
>
> Key: HDFS-17111
> URL: https://issues.apache.org/jira/browse/HDFS-17111
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
>
> Right now when a client MSYNCs to the router, the call is fanned out to all
> nameservices. We only need to proxy the msync to nameservices that have
> observer reads configured.
> We can do this either by adding a new config for the admin to specify which
> nameservices have CRS configured, or we can try to automatically detect these.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
