[ 
https://issues.apache.org/jira/browse/HDFS-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199303#comment-13199303
 ] 

Hudson commented on HDFS-2877:
------------------------------

Integrated in Hadoop-Common-0.23-Commit #474 (See 
[https://builds.apache.org/job/Hadoop-Common-0.23-Commit/474/])
    HDFS-2877. If locking of a storage dir fails, it will remove the other NN's 
lock file on exit. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239879
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java

                
> If locking of a storage dir fails, it will remove the other NN's lock file on 
> exit
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-2877
>                 URL: https://issues.apache.org/jira/browse/HDFS-2877
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0, 0.24.0, 1.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.24.0, 0.23.1, 1.1.0, 0.22.1
>
>         Attachments: hdfs-2877.txt
>
>
> In {{Storage.tryLock()}}, we call {{lockF.deleteOnExit()}} regardless of 
> whether we successfully lock the directory. So, if another NN has the 
> directory locked, then we'll fail to lock it the first time we start another 
> NN. But our failed start attempt will still remove the other NN's lockfile, 
> and a second attempt will erroneously start.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to