[ https://issues.apache.org/jira/browse/HDFS-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199371#comment-13199371 ]
Aaron T. Myers commented on HDFS-2718: -------------------------------------- bq. I think the construction of filenames in TestEditLog may be buggy – I think you mean to do "/filename" + (startIndex + i) since otherwise it will do two string-appends, rather than a string append of an addition. To address this issue, why not use the exact same code as was used in the patch for HDFS-2602? It doesn't have this bug, and will make merges a little bit easier. > Optimize OP_ADD in edits loading > -------------------------------- > > Key: HDFS-2718 > URL: https://issues.apache.org/jira/browse/HDFS-2718 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.22.0, 0.24.0, 1.0.0 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Fix For: 0.24.0, 0.23.1, 0.22.1 > > Attachments: editsLoader-0.22.patch, editsLoader-0.22.patch, > editsLoader-0.22.patch, editsLoader-trunk.patch, editsLoader-trunk.patch, > editsLoader-trunk.patch, editsLoader-trunk.patch > > > During loading the edits journal FSEditLog.loadEditRecords() processes OP_ADD > inefficiently. It first removes the existing INodeFile from the directory > tree, then adds it back as a regular INodeFile, and then replaces it with > INodeFileUnderConstruction if files is not closed. This slows down edits > loading. OP_ADD should be done in one shot and retain previously existing > data. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira