[ 
https://issues.apache.org/jira/browse/HDFS-17149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752303#comment-17752303
 ] 

farmmamba commented on HDFS-17149:
----------------------------------

[~hexiaoqiao] Sir, thanks a lot for pointing that.  I have read the comments in 
HDFS-15079 and i think current issue is different from HDFS-15079.

The parameter clientMachine in  FSNamesystem#sortLocatedBlocks method is 
router's ip address which should be actual client ip i think.

> getBlockLocations RPC should use actual client ip to compute network distance 
> when using RBF.
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17149
>                 URL: https://issues.apache.org/jira/browse/HDFS-17149
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namanode
>    Affects Versions: 3.4.0
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>
> Please correct me if i understand wrongly. Thanks.
> Currently, when a getBlockLocations RPC forwards to namenode via router.  
> NameNode will use router ip address as client machine to compute network 
> distance against block's locations. See FSNamesystem#sortLocatedBlocks method 
> for more detailed information.  
> I think this compute method is not correct and should use actual client ip.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to