[ https://issues.apache.org/jira/browse/HDFS-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755086#comment-17755086 ]
ASF GitHub Bot commented on HDFS-17160: --------------------------------------- hfutatzhanghb opened a new pull request, #5952: URL: https://github.com/apache/hadoop/pull/5952 ### Description of PR Currently in method flushOrSync, it will only increase fsyncCount once when `isSync == true`. But actually we fsync twice when `checksumOut != null` and `streams.getDataOut() != null`. So we should increase fsync count twice. > Metrics fsyncCount should be computed correctly in flushOrSync > -------------------------------------------------------------- > > Key: HDFS-17160 > URL: https://issues.apache.org/jira/browse/HDFS-17160 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.4.0 > Reporter: farmmamba > Assignee: farmmamba > Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org