[
https://issues.apache.org/jira/browse/HDFS-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755359#comment-17755359
]
ASF GitHub Bot commented on HDFS-17161:
---------------------------------------
tonyPan123 opened a new pull request, #5956:
URL: https://github.com/apache/hadoop/pull/5956
…s socket on IOException
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
In [HDFS-13039](https://issues.apache.org/jira/browse/HDFS-13039), it is
proposed a situation in which an IOException during
StripedBlockReader#createBlockReader has potential to leak the socket. However,
in [HDFS-13039](https://issues.apache.org/jira/browse/HDFS-13039), the test
patch is still missed. Then in this case, we add a unit test to reproduce that.
From the test results, when the patch in HDFS-13039 is removed, the test would
failed while the test could pass when the patch is added back.
Any comments and suggestions would be appreciated.
### How was this patch tested?
The case itself is about a unit test
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Adding test for StripedBlockReader#createBlockReader leaks socket on
> IOException
> --------------------------------------------------------------------------------
>
> Key: HDFS-17161
> URL: https://issues.apache.org/jira/browse/HDFS-17161
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, erasure-coding
> Affects Versions: 3.3.6
> Reporter: Haoze Wu
> Priority: Major
>
> In [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], it is
> proposed a situation in which an IOException during
> StripedBlockReader#createBlockReader has potential to leak the socket.
> However, in [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039],
> the test patch is still missed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
