[
https://issues.apache.org/jira/browse/HDFS-17180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763357#comment-17763357
]
ASF GitHub Bot commented on HDFS-17180:
---------------------------------------
zhtttylz commented on code in PR #6028:
URL: https://github.com/apache/hadoop/pull/6028#discussion_r1320609587
##########
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java:
##########
@@ -2201,6 +2204,45 @@ private void testGetECCodecs() throws Exception {
}
}
+ private void testGetTrashRoots() throws Exception {
+ if (isLocalFS()) {
+ // do not test the getAllEEPolicies for local FS.
+ return;
+ }
+ final Path path = new Path("/");
+ FileSystem fs = FileSystem.get(path.toUri(), this.getProxiedFSConf());
+ if (fs instanceof DistributedFileSystem) {
+ DistributedFileSystem dfs =
+ (DistributedFileSystem) FileSystem.get(path.toUri(),
this.getProxiedFSConf());
+ FileSystem httpFs = this.getHttpFSFileSystem();
+
+ // Create trash root for user0
+ UserGroupInformation ugi =
UserGroupInformation.createRemoteUser("user0");
+ String user0HomeStr =
DFSUtilClient.getHomeDirectory(this.getProxiedFSConf(), ugi);
+ Path user0Trash = new Path(user0HomeStr, FileSystem.TRASH_PREFIX);
+ dfs.mkdirs(user0Trash);
+
+ Collection<FileStatus> dfsTrashRoots = dfs.getTrashRoots(true);
+ Collection<FileStatus> diffTrashRoots = null;
+
+ if (httpFs instanceof HttpFSFileSystem) {
+ HttpFSFileSystem httpFS = (HttpFSFileSystem) httpFs;
+ diffTrashRoots = httpFS.getTrashRoots(true);
+ } else if (httpFs instanceof WebHdfsFileSystem) {
+ WebHdfsFileSystem webHdfsFileSystem = (WebHdfsFileSystem) httpFs;
+ diffTrashRoots = webHdfsFileSystem.getTrashRoots(true);
+ } else {
+ Assert.fail(fs.getClass().getSimpleName() +
+ " is not of type HttpFSFileSystem or WebHdfsFileSystem");
+ }
+
+ //Validate getTrashRoots are the same as DistributedFileSystem
Review Comment:
Thanks for your suggestion, I'll make the required code changes promptly
> HttpFS Add Support getTrashRoots API
> ------------------------------------
>
> Key: HDFS-17180
> URL: https://issues.apache.org/jira/browse/HDFS-17180
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: webhdfs
> Affects Versions: 3.4.0
> Reporter: Hualong Zhang
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
>
> We should ensure that WebHDFS remains synchronized with HttpFS, as the former
> has already implemented the *getTrashRoots* interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
