[ 
https://issues.apache.org/jira/browse/HDFS-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768417#comment-17768417
 ] 

ASF GitHub Bot commented on HDFS-17209:
---------------------------------------

yuw1 opened a new pull request, #6110:
URL: https://github.com/apache/hadoop/pull/6110

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Correct comments to align with the code
> ---------------------------------------
>
>                 Key: HDFS-17209
>                 URL: https://issues.apache.org/jira/browse/HDFS-17209
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.3.6
>            Reporter: Yu Wang
>            Priority: Trivial
>
> The waiting time in the comments is inconsistent with the code in 
> DataNode.java
> {code:java}
> public void shutdown() {
> ...
>   while (true) {
>     // When shutting down for restart, wait 2.5 seconds before forcing
>     // termination of receiver threads.
>     if (!this.shutdownForUpgrade ||
>         (this.shutdownForUpgrade && (Time.monotonicNow() - timeNotified
>             > 1000))) {
>       this.threadGroup.interrupt();
>       break;
>     }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to