[ https://issues.apache.org/jira/browse/HDFS-17133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770312#comment-17770312 ]
Ayush Saxena commented on HDFS-17133: ------------------------------------- Committed to trunk. Thanx [~FuzzingTeam] for the contribution!!! > TestFsDatasetImpl missing null check when cleaning up > ----------------------------------------------------- > > Key: HDFS-17133 > URL: https://issues.apache.org/jira/browse/HDFS-17133 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: ConfX > Assignee: ConfX > Priority: Critical > Labels: pull-request-available > Attachments: reproduce.sh > > > h2. What happened > I turned on {{dfs.namenode.quota.init-threads=1468568631}} and then the test > {{{}org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl#testMoveBlockFailure{}}}fails > with null pointer. > h2. Where's the problem > In the clean up part of the test: > {noformat} > } finally { > if (cluster.isClusterUp()) { > cluster.shutdown(); > } > }{noformat} > if cluster is null, the test would directly fail with a null pointer > exception and hiding potentially the actual failure. > h2. How to reproduce > # set {{{}dfs.namenode.quota.init-threads{}}}={{{}1468568631 {}}} > # run > {{org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl#testMoveBlockFailure}} > you should observe > {noformat} > java.lang.NullPointerException > at > org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl.testMoveBlockFailure(TestFsDatasetImpl.java:1005){noformat} > For an easy reproduction, run the reproduce.sh in the attachment. > We are happy to provide a patch if this issue is confirmed. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org