[
https://issues.apache.org/jira/browse/HDFS-17171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770319#comment-17770319
]
ASF GitHub Bot commented on HDFS-17171:
---------------------------------------
ayushtkn commented on code in PR #5996:
URL: https://github.com/apache/hadoop/pull/5996#discussion_r1340969835
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -614,6 +616,8 @@ public Map<String, Long> load(String key) {
new DataTransferThrottler(100, ecReconstuctReadBandwidth) : null;
this.ecReconstuctWriteThrottler = ecReconstuctWriteBandwidth > 0 ?
new DataTransferThrottler(100, ecReconstuctWriteBandwidth) : null;
+ this.congestionRatio =
conf.getDouble(DFSConfigKeys.DFS_PIPELINE_CONGESTION_RATIO,
+ DFSConfigKeys.DFS_PIPELINE_CONGESTION_RATIO_DEFAULT);
Review Comment:
should validate the value is positive, if not put a warn log & use default
> CONGESTION_RATIO should be configurable
> ---------------------------------------
>
> Key: HDFS-17171
> URL: https://issues.apache.org/jira/browse/HDFS-17171
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.4.0
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> Currently, The valuee of DataNode#CONGESTION_RATIO is 1.5 and it is not
> configurable.
> When the average load of a datanode in last one minute is higer than
> CONGESTION_RATIO * NUM_CORES, this datanode will be regard as CONGESTED.
> In most real production envs, the default value 1.5 seems not appropriate.
> So ,we should change this value to be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
