[
https://issues.apache.org/jira/browse/HDFS-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771035#comment-17771035
]
ASF GitHub Bot commented on HDFS-17213:
---------------------------------------
ayushtkn commented on code in PR #6134:
URL: https://github.com/apache/hadoop/pull/6134#discussion_r1342504971
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java:
##########
@@ -1925,6 +1925,42 @@ public void testAddMultipleMountPointsFailure() throws
Exception {
err.toString().contains("Cannot add mount points:
[/testAddMultiMountPoints-01"));
}
+ @Test
+ public void testGetUsage() throws Exception {
Review Comment:
this test is pretty irrelevant in the context, you are checking the exit
codes here, where you didn't even touch them, there should be an existing test
I believe which tests the help output
> In RouterAdmin class,"if else" is not as elegant as "switch case".
> ------------------------------------------------------------------
>
> Key: HDFS-17213
> URL: https://issues.apache.org/jira/browse/HDFS-17213
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Affects Versions: 3.3.4
> Reporter: xiaojunxiang
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2023-10-01-21-29-22-983.png
>
>
> In RouterAdmin class, "if else" is not as elegant as "switch case" in the
> admin command parameters section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
