[ 
https://issues.apache.org/jira/browse/HDFS-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773516#comment-17773516
 ] 

ASF GitHub Bot commented on HDFS-17210:
---------------------------------------

GuoPhilipse commented on code in PR #6113:
URL: https://github.com/apache/hadoop/pull/6113#discussion_r1351263655


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java:
##########
@@ -1240,6 +1240,12 @@ public class DFSConfigKeys extends 
CommonConfigurationKeys {
   public static final int
       
DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_TOLERANCE_DEFAULT
 =
       5;
+  public static final String
+          
DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_TOLERANCE_LIMIT_KEY
 =

Review Comment:
   hi @Hexiaoqiao  ,i kept the Align as other configuration item and fixed the 
checkstyle items.  but  
```DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_TOLERANCE_LIMIT_DEFAULT```
 is still a bit long(over 100 per line), do you have better ideas? 





> Optimize AvailableSpaceBlockPlacementPolicy
> -------------------------------------------
>
>                 Key: HDFS-17210
>                 URL: https://issues.apache.org/jira/browse/HDFS-17210
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.3.6
>            Reporter: Fei Guo
>            Priority: Minor
>              Labels: pull-request-available
>
> for now ,we may have many nodes usage over 85%, some nodes'usage have been 
> over 90%, if we choose three nodes as nodeA-97%,nodeB-98%,nodeC-99%, actually 
> i don't want nodeC(99%) be choosen, for nodeC usage is really high , even 
> random chance ,nodeC will reach 100% soon, so we can directly choose the less 
> usage node(nodeA) if all nodes's usage are over 95%(just a example)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to