[ 
https://issues.apache.org/jira/browse/HDFS-17215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774242#comment-17774242
 ] 

ASF GitHub Bot commented on HDFS-17215:
---------------------------------------

ayushtkn commented on code in PR #6136:
URL: https://github.com/apache/hadoop/pull/6136#discussion_r1355794059


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/protocol/impl/pb/FederationProtocolPBTranslator.java:
##########
@@ -54,7 +54,7 @@ public FederationProtocolPBTranslator(Class<P> protoType) {
    * the proto handler this translator holds.
    */
   @SuppressWarnings("unchecked")
-  public void setProto(Message p) {
+  public void setProto(Message p) throws IllegalArgumentException {  // 
unchecked exception

Review Comment:
   @xiaojunxiang2023 can you address this? we can commit post this





> The setQuota method annotation of the Quota class has an error
> --------------------------------------------------------------
>
>                 Key: HDFS-17215
>                 URL: https://issues.apache.org/jira/browse/HDFS-17215
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>    Affects Versions: 3.3.4
>            Reporter: xiaojunxiang
>            Priority: Minor
>              Labels: pull-request-available
>
> The setQuota method annotation of the Quota class has an error, which is 
> described in the @throws section.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to