[ 
https://issues.apache.org/jira/browse/HDFS-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788955#comment-17788955
 ] 

ASF GitHub Bot commented on HDFS-17261:
---------------------------------------

LiuGuH commented on code in PR #6288:
URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402864449


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -2188,11 +2188,12 @@ private static FsPermission getParentPermission(final 
FsPermission mask) {
    * @param name Name of the mount point.
    * @param childrenNum Number of children.
    * @param date Map with the dates.
+   * @param setPath if true should set path in HdfsFileStatus
    * @return New HDFS file status representing a mount point.
    */
   @VisibleForTesting
   HdfsFileStatus getMountPointStatus(
-      String name, int childrenNum, long date) {
+      String name, int childrenNum, long date, boolean setPath) {

Review Comment:
   Sorry , I don't understand how to implements it without add a boolean 
argument in getMountPointStatus(). Any example for this,Thanks





> RBF: Fix getFileInfo return wrong path when get mountTable path which 
> multi-level
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-17261
>                 URL: https://issues.apache.org/jira/browse/HDFS-17261
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: liuguanghua
>            Priority: Minor
>              Labels: pull-request-available
>
> With DFSRouter, Suppose there are two nameservices : ns0,ns1
>  # Add mountTable      /testgetfileinfo/ns1/dir  -> (ns1 -> 
> /testgetfileinfo/ns1/dir) 
>  # hdfs client via DFSRouter accesses a directory:   hdfs dfs -ls -d 
> /testgetfileinfo
>  # it will return worng path :    /testgetfileinfo/testgetfileinfo
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to