[ 
https://issues.apache.org/jira/browse/HDFS-16749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792313#comment-17792313
 ] 

ASF GitHub Bot commented on HDFS-16749:
---------------------------------------

slfan1989 commented on code in PR #6317:
URL: https://github.com/apache/hadoop/pull/6317#discussion_r1412718229


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java:
##########
@@ -276,7 +276,7 @@ public void testMultipleMountPoint() throws IOException,
 
     // Client user see global trash view, wo should see all three mount point.
     FileStatus[] fileStatuses = fs.listStatus(new 
Path("/user/test-trash/.Trash/Current/"));
-    assertEquals(3, fileStatuses.length);
+    assertEquals(2, fileStatuses.length);

Review Comment:
   I modified the description and let's wait for other partners' suggestions. 
My personal suggestion is that we'd better solve the problem with smaller 
changes. (#5039)



##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java:
##########
@@ -276,7 +276,7 @@ public void testMultipleMountPoint() throws IOException,
 
     // Client user see global trash view, wo should see all three mount point.
     FileStatus[] fileStatuses = fs.listStatus(new 
Path("/user/test-trash/.Trash/Current/"));
-    assertEquals(3, fileStatuses.length);
+    assertEquals(2, fileStatuses.length);

Review Comment:
   I modified the description and let's wait for other partners' suggestions. 
My personal suggestion is that we'd better solve the issue with smaller 
changes. (#5039)





> RBF: Gets the wrong directory information from Trash
> ----------------------------------------------------
>
>                 Key: HDFS-16749
>                 URL: https://issues.apache.org/jira/browse/HDFS-16749
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rbf
>    Affects Versions: 3.4.0
>            Reporter: Xiping Zhang
>            Assignee: Xiping Zhang
>            Priority: Critical
>              Labels: pull-request-available
>
>  *Liststatus trash path, some directory information that does not exist is 
> returned. Look at the following example:*
> // Current User :zhangxiping
> // router  =》  ns0 ,ns1 
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfsrouteradmin -ls{color}
> Mount Table Entries:
> Source                    Destinations              Owner                     
> Group                     Mode       Quota/Usage
> /user/a                   ns0->/user/a(Priority:0,Readonly:false) zhangxiping 
>               Administrators            rwxr-xr-x  [NsQuota: -/-, SsQuota: 
> -/-]
> /user/b                   ns0->/user/b(Priority:0,Readonly:false) zhangxiping 
>               Administrators            rwxr-xr-x  [NsQuota: -/-, SsQuota: 
> -/-]
> /user/c                   ns0->/user/c(Priority:0,Readonly:false) zhangxiping 
>               Administrators            rwxr-xr-x  [NsQuota: -/-, SsQuota: 
> -/-]
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls hdfs://ns0/user{color}
> Found 4 items
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:17 
> hdfs://ns0/user/a
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:17 
> hdfs://ns0/user/b
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:17 
> hdfs://ns0/user/c
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:11 
> hdfs://ns0/user/zhangxiping
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls hdfs://ns1/user{color}
> ls: `hdfs://ns1/user': No such file or directory
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls 
> hdfs://ns0/user/zhangxiping/.Trash/Current/user{color}
> Found 1 items
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:14 
> hdfs://ns0/user/zhangxiping/.Trash/Current/user/d
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls 
> /user/zhangxiping/.Trash/Current/user      //Requests to the router{color}
> Found 4 items
> drwxrwxrwx   - zhangxiping supergroup          0 1970-01-01 08:00 
> /user/zhangxiping/.Trash/Current/user/a  
> {color:#00875a}drwxrwxrwx   - zhangxiping supergroup          0 1970-01-01 
> 08:00 /user/zhangxiping/.Trash/Current/user/b{color}
> {color:#00875a}drwxrwxrwx   - zhangxiping supergroup          0 1970-01-01 
> 08:00 /user/zhangxiping/.Trash/Current/user/c    *//The records on it 
> shouldn't exist*{color}
> drwxr-xr-x     - zhangxiping supergroup          0 2022-10-18 10:14 
> /user/zhangxiping/.Trash/Current/user/d



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to