[jira] [Commented] (HDFS-17260) Fix the logic for reconfigure slow peer enable for Namenode.

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/HDFS-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792328#comment-17792328
 ] 

ASF GitHub Bot commented on HDFS-17260:
---------------------------------------

haiyang1987 commented on code in PR #6279:
URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412726494


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicyExcludeSlowNodes.java:
##########
@@ -136,4 +138,41 @@ public void testChooseTargetExcludeSlowNodes() throws 
Exception {
     NameNode.LOG.info("Done working on it");
   }
 
+  @Test
+  public void testSlowPeerTrackerEnabledClearSlowNodes() throws Exception {
+    namenode.getNamesystem().writeLock();
+    try {
+      // add nodes
+      for (DatanodeDescriptor dataNode : dataNodes) {
+        dnManager.addDatanode(dataNode);
+      }
+
+      // mock slow nodes
+      SlowPeerTracker tracker = dnManager.getSlowPeerTracker();
+      assert tracker != null;
+      OutlierMetrics outlierMetrics = new OutlierMetrics(0.0, 0.0, 0.0, 5.0);
+      tracker.addReport(dataNodes[0].getInfoAddr(), dataNodes[3].getInfoAddr(),
+          outlierMetrics);
+      tracker.addReport(dataNodes[1].getInfoAddr(), dataNodes[3].getInfoAddr(),
+          outlierMetrics);
+      tracker.addReport(dataNodes[2].getInfoAddr(), dataNodes[3].getInfoAddr(),
+          outlierMetrics);
+
+      // waiting for slow nodes collector run
+      Thread.sleep(3000);

Review Comment:
    
   can use:
   ```
   GenericTestUtils.waitFor(
             () -> DatanodeManager.getSlowNodesUuidSet().size() == 3,
             100, 3000);
   ```





> Fix the logic for reconfigure slow peer enable for Namenode.
> ------------------------------------------------------------
>
>                 Key: HDFS-17260
>                 URL: https://issues.apache.org/jira/browse/HDFS-17260
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: huangzhaobo99
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org