[
https://issues.apache.org/jira/browse/HDFS-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792368#comment-17792368
]
ASF GitHub Bot commented on HDFS-17260:
---------------------------------------
huangzhaobo99 commented on code in PR #6279:
URL: https://github.com/apache/hadoop/pull/6279#discussion_r1412783688
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/SlowPeerDisabledTracker.java:
##########
@@ -46,11 +46,6 @@ public class SlowPeerDisabledTracker extends SlowPeerTracker
{
public SlowPeerDisabledTracker(Configuration conf, Timer timer) {
super(conf, timer);
- final boolean dataNodePeerStatsEnabledVal =
- conf.getBoolean(DFSConfigKeys.DFS_DATANODE_PEER_STATS_ENABLED_KEY,
- DFSConfigKeys.DFS_DATANODE_PEER_STATS_ENABLED_DEFAULT);
- Preconditions.checkArgument(!dataNodePeerStatsEnabledVal,
- "SlowPeerDisabledTracker should only be used for disabled slow peer
stats.");
Review Comment:
@haiyang1987
we will proceed with the original processing, there is no validation in
SlowPeerTracker,
In SlowPeerDisabledTracker, we will first remove this invalid
validation.`getConf().setBoolean(DFS_DATANODE_PEER_STATS_ENABLED_KEY,
peerStatsEnabled);`
If ‘setConf’ in advance, the logic of the original reconfig may have a
slightly different meaning, because in the production environment, the
configuration is changed through reconfigureProperty and then the configuration
in memory is refreshed.
> Fix the logic for reconfigure slow peer enable for Namenode.
> ------------------------------------------------------------
>
> Key: HDFS-17260
> URL: https://issues.apache.org/jira/browse/HDFS-17260
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: huangzhaobo99
> Assignee: huangzhaobo99
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
