[
https://issues.apache.org/jira/browse/HDFS-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794572#comment-17794572
]
ASF GitHub Bot commented on HDFS-17273:
---------------------------------------
haiyang1987 commented on code in PR #6321:
URL: https://github.com/apache/hadoop/pull/6321#discussion_r1420072279
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -937,13 +935,13 @@ void waitForAckedSeqno(long seqno) throws IOException {
try {
dataQueue.wait(1000); // when we receive an ack, we notify on
long duration = Time.monotonicNowNanos() - begin;
- if (duration > writeTimeout * NANOSECONDS_PER_MILLISECOND) {
+ if (TimeUnit.NANOSECONDS.toMillis(duration) > writeTimeout) {
LOG.error("No ack received, took {}ms (threshold={}ms). "
+ "File being written: {}, block: {}, "
+ "Write pipeline datanodes: {}.",
- duration / NANOSECONDS_PER_MILLISECOND, writeTimeout, src,
block, nodes);
+ TimeUnit.NANOSECONDS.toSeconds(duration), writeTimeout,
src, block, nodes);
Review Comment:
TimeUnit.NANOSECONDS.toMillis(duration) ？
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -937,13 +935,13 @@ void waitForAckedSeqno(long seqno) throws IOException {
try {
dataQueue.wait(1000); // when we receive an ack, we notify on
long duration = Time.monotonicNowNanos() - begin;
- if (duration > writeTimeout * NANOSECONDS_PER_MILLISECOND) {
+ if (TimeUnit.NANOSECONDS.toMillis(duration) > writeTimeout) {
LOG.error("No ack received, took {}ms (threshold={}ms). "
+ "File being written: {}, block: {}, "
+ "Write pipeline datanodes: {}.",
- duration / NANOSECONDS_PER_MILLISECOND, writeTimeout, src,
block, nodes);
+ TimeUnit.NANOSECONDS.toSeconds(duration), writeTimeout,
src, block, nodes);
Review Comment:
TimeUnit.NANOSECONDS.toMillis(duration) ？
> Change the way of computing some local variables duration for better debugging
> ------------------------------------------------------------------------------
>
> Key: HDFS-17273
> URL: https://issues.apache.org/jira/browse/HDFS-17273
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
