[
https://issues.apache.org/jira/browse/HDFS-17284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795993#comment-17795993
]
ASF GitHub Bot commented on HDFS-17284:
---------------------------------------
hfutatzhanghb commented on code in PR #6348:
URL: https://github.com/apache/hadoop/pull/6348#discussion_r1424826707
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestDatanodeManager.java:
##########
@@ -1126,4 +1127,33 @@ public MockDfsNetworkTopology(){
super();
}
}
+
+ @Test
+ public void testComputeReconstructedTaskNum() {
+ int xmitsInProgress = 13000000;
Review Comment:
One minor suggestion. We should better add an UT that `totalReplicateBlocks
* maxTransfers` overflow been fixed here, because it is the reason causes
xmitsInProgress be very large. Others LGTM.
> Fix int overflow in calculating numEcReplicatedTasks and numReplicationTasks
> during block recovery
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-17284
> URL: https://issues.apache.org/jira/browse/HDFS-17284
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Hualong Zhang
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
>
> Fix int overflow in calculating numEcReplicatedTasks and numReplicationTasks
> during block recovery
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
