[ https://issues.apache.org/jira/browse/HDFS-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800135#comment-17800135 ]
ASF GitHub Bot commented on HDFS-17056: --------------------------------------- huangzhaobo99 commented on code in PR #6379: URL: https://github.com/apache/hadoop/pull/6379#discussion_r1435762664 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/ECAdmin.java: ########## @@ -642,6 +642,10 @@ public int run(Configuration conf, List<String> args) throws IOException { throw e; } } else { + if (args.size() > 0) { + System.err.println(getName() + ": Too many arguments"); Review Comment: 1. It looks good! However, if multiple EC policies are enabled in the cluster, use `bin/hdfs ec -verifyClusterSetup` command is incorrect. 2. The reasons are as follows: `DistributedFileSystem#getECTopologyResultForPolicies` can only return one result (ECTopologyVerifierResult). ```java /** * Verifies if the given policies are supported in the given cluster setup. * If not policy is specified checks for all enabled policies. * @param policyNames name of policies. * @return the result if the given policies are supported in the cluster setup * @throws IOException */ public ECTopologyVerifierResult getECTopologyResultForPolicies( final String... policyNames) throws IOException { return dfs.getECTopologyResultForPolicies(policyNames); } ``` 3. Modify to require specifying the `-policy` param? Or modify the return value of `DistributedFileSystem#getECTopologyResultForPolicies`? > EC: Fix verifyClusterSetup output in case of an invalid param. > -------------------------------------------------------------- > > Key: HDFS-17056 > URL: https://issues.apache.org/jira/browse/HDFS-17056 > Project: Hadoop HDFS > Issue Type: Bug > Components: ec > Reporter: Ayush Saxena > Assignee: huangzhaobo99 > Priority: Major > Labels: newbie, pull-request-available > > {code:java} > bin/hdfs ec -verifyClusterSetup XOR-2-1-1024k > 9 DataNodes are required for the erasure coding policies: RS-6-3-1024k, > XOR-2-1-1024k. The number of DataNodes is only 3. {code} > verifyClusterSetup requires -policy then the name of policies, else it > defaults to all enabled policies. > In case there are additional invalid options it silently ignores them, unlike > other EC commands which throws out Too Many Argument exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org