[ https://issues.apache.org/jira/browse/HDFS-17301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800781#comment-17800781 ]
ASF GitHub Bot commented on HDFS-17301: --------------------------------------- tasanuma commented on PR #6377: URL: https://github.com/apache/hadoop/pull/6377#issuecomment-1870347567 @huangzhaobo99 Thanks for your PR. It looks very good to me. Just one minor suggestion, the usage of assertEquals should be `assertEquals(expected, actual)`, but you have it the other way around in your code. > Add read and write dataXceiver threads count metrics to datanode. > ----------------------------------------------------------------- > > Key: HDFS-17301 > URL: https://issues.apache.org/jira/browse/HDFS-17301 > Project: Hadoop HDFS > Issue Type: New Feature > Reporter: huangzhaobo99 > Assignee: huangzhaobo99 > Priority: Major > Labels: pull-request-available > > # The DataNodeActiveXeiversCount metric contains the number of threads of all > Op types. > # In most cases, we focus more on the number of read and write dataXceiver > threads, so add read and write dataXceiver threads count metrics to datanode. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org