[
https://issues.apache.org/jira/browse/HDFS-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801776#comment-17801776
]
ASF GitHub Bot commented on HDFS-17306:
---------------------------------------
LiuGuH commented on code in PR #6385:
URL: https://github.com/apache/hadoop/pull/6385#discussion_r1439428230
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterStateIdContext.java:
##########
@@ -85,7 +85,11 @@ public void
setResponseHeaderState(RpcResponseHeaderProto.Builder headerBuilder)
return;
}
RouterFederatedStateProto.Builder builder =
RouterFederatedStateProto.newBuilder();
- namespaceIdMap.forEach((k, v) -> builder.putNamespaceStateIds(k, v.get()));
+ namespaceIdMap.forEach((k, v) -> {
Review Comment:
Done, Thanks
> RBF:Router should not return nameservices that does not enable observer nodes
> in RpcResponseHeaderProto
> -------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17306
> URL: https://issues.apache.org/jira/browse/HDFS-17306
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: liuguanghua
> Priority: Major
> Labels: pull-request-available
>
> If a cluster has 3 nameservices: ns1, ns2,ns3, and ns1 has observer
> nodes, and client via DFSRouter comminutes with nns.
> If DFS_ROUTER_OBSERVER_READ_DEFAULT_KEY enable, the client will
> receive all nameservices in RpcResponseHeaderProto.
> We should reduce rpc response size if nameservices don't enable
> observer nodes.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
