[
https://issues.apache.org/jira/browse/HDFS-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802128#comment-17802128
]
ASF GitHub Bot commented on HDFS-17317:
---------------------------------------
ayushtkn commented on code in PR #6402:
URL: https://github.com/apache/hadoop/pull/6402#discussion_r1440351242
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##########
@@ -306,7 +306,7 @@ int run(List<String> args) throws IOException {
new BufferedOutputStream(Files.newOutputStream(srcMeta.toPath()),
smallBufferSize));
BlockMetadataHeader.writeHeader(metaOut, checksum);
- metaOut.close();
+ metaOut.flush();
Review Comment:
I think close itself is ok, we can avoid closing in the finally block if the
stream is already closing, rather than flushing here & then closing below,
close would be calling flush before closing itself.
in general I don't think it isn't a big problem, maybe just dereference the
metaOut after close
```
metaOut.close();
metaOut = null;
```
> DebugAdmin metaOut not need multiple close
> -------------------------------------------
>
> Key: HDFS-17317
> URL: https://issues.apache.org/jira/browse/HDFS-17317
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: xy
> Priority: Major
> Labels: pull-request-available
>
> DebugAdmin metaOut not need multiple close
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
