[
https://issues.apache.org/jira/browse/HDFS-15354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802417#comment-17802417
]
Shilun Fan edited comment on HDFS-15354 at 1/4/24 8:13 AM:
-----------------------------------------------------------
Bulk update: moved all 3.4.0 non-blocker issues, please move back if it is a
blocker. Retarget 3.5.0.
was (Author: slfan1989):
updated the target version for preparing 3.4.0 release.
> clearCorruptLazyPersistFiles incrementalBlock removal should be out side
> write lock
> -----------------------------------------------------------------------------------
>
> Key: HDFS-15354
> URL: https://issues.apache.org/jira/browse/HDFS-15354
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.2.1
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Major
>
> In LazyPersistFileScrubber#clearCorruptLazyPersistFiles collecting blocks
> for removal and also removing them in write lock.
> removeBlocks should be moved out of writelock as removeBlocks has incremental
> deletion logic in which it will acquire write lock and unlock for every block
> removal.
> If there are more corrupt blocks to remove in cluster, it may hold write lock
> for longer time.
> {code:java}
> for (BlockCollection bc : filesToDelete) {
> LOG.warn("Removing lazyPersist file " + bc.getName() + " with no
> replicas.");
> BlocksMapUpdateInfo toRemoveBlocks =
> FSDirDeleteOp.deleteInternal(
> FSNamesystem.this,
> INodesInPath.fromINode((INodeFile) bc), false);
> changed |= toRemoveBlocks != null;
> if (toRemoveBlocks != null) {
> removeBlocks(toRemoveBlocks); // Incremental deletion of blocks
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
