[ 
https://issues.apache.org/jira/browse/HDFS-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811766#comment-17811766
 ] 

ASF GitHub Bot commented on HDFS-17353:
---------------------------------------

ssanchozz commented on code in PR #6491:
URL: https://github.com/apache/hadoop/pull/6491#discussion_r1469233706


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpcMultiDestination.java:
##########
@@ -475,7 +475,7 @@ public void testCallerContextWithMultiDestinations() throws 
IOException {
 
     String auditFlag = "src=" + dirPath.toString();
     String clientIpInfo = "clientIp:"
-        + InetAddress.getLocalHost().getHostAddress();
+        + InetAddress.getByName("localhost").getHostAddress();

Review Comment:
   I've checked on Windows, works just fine. In Java doc there is no a note 
that it's Linux only: 
https://docs.oracle.com/javase/8/docs/api/java/net/InetAddress.html#getByName-java.lang.String-
   
   Main:
   `System.out.println(System.getProperty("os.name"));`
   `InetAddress localhost = InetAddress.getByName("localhost");`
   `System.out.println(localhost.getHostAddress());`
   
   Output:
   `Windows 10`
   `127.0.0.1`





> Fix failing RBF module tests
> ----------------------------
>
>                 Key: HDFS-17353
>                 URL: https://issues.apache.org/jira/browse/HDFS-17353
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Alexander Bogdanov
>            Priority: Major
>              Labels: pull-request-available
>
> 3 tests are failing in RBF module:
>  *  TestRouterRpcMultiDestination.testCallerContextWithMultiDestinations
>  * TestRouterRpcMultiDestination>TestRouterRpc.testMkdirsWithCallerContext
>  * 
> TestRouterRpcMultiDestination>TestRouterRpc.testRealUserPropagationInCallerContext
> Need to fix them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to