[ https://issues.apache.org/jira/browse/HDFS-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813270#comment-17813270 ]
ASF GitHub Bot commented on HDFS-17359: --------------------------------------- tasanuma commented on PR #6503: URL: https://github.com/apache/hadoop/pull/6503#issuecomment-1921517899 Merged. Thanks for your contribution! @hfutatzhanghb > EC: recheck failed streamers should only after flushing all packets. > -------------------------------------------------------------------- > > Key: HDFS-17359 > URL: https://issues.apache.org/jira/browse/HDFS-17359 > Project: Hadoop HDFS > Issue Type: Improvement > Components: ec > Reporter: farmmamba > Assignee: farmmamba > Priority: Minor > Labels: pull-request-available > > In method DFSStripedOutputStream#checkStreamerFailures, we have below codes: > {code:java} > Set<StripedDataStreamer> newFailed = checkStreamers(); > if (newFailed.size() == 0) { > return; > } if (isNeedFlushAllPackets) { > // for healthy streamers, wait till all of them have fetched the new > block > // and flushed out all the enqueued packets. > flushAllInternals(); > } > // recheck failed streamers again after the flush > newFailed = checkStreamers(); {code} > We should better move the re-check logic into if condition to reduce useless > invocation. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org