[ 
https://issues.apache.org/jira/browse/HDFS-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203006#comment-13203006
 ] 

Todd Lipcon commented on HDFS-2579:
-----------------------------------

We've found one bug during stress testing - there's a super-rare race here if 
the secret manager happens to be calling logUpdateMasterKey exactly when the NN 
wants to stop the secret manager. The issue is that the "stopSecretManager" 
call is holding the FSNamesystem lock, but the secret manager thread is waiting 
on the same lock.

The solution is to have the secret manager use lockInterruptibly instead.
                
> Starting delegation token manager during safemode fails
> -------------------------------------------------------
>
>                 Key: HDFS-2579
>                 URL: https://issues.apache.org/jira/browse/HDFS-2579
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, name-node, security
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2579.txt, hdfs-2579.txt
>
>
> I noticed this on the HA branch, but it seems to actually affect non-HA 
> branch 0.23 if security is enabled. When the NN starts up, if security is 
> enabled, we start the delegation token secret manager, which then tries to 
> call {{logUpdateMasterKey}}. This fails because the edit logs may not be 
> written while in safe-mode.
> It seems to me that there's not any necessary reason that you have to make a 
> new master key at startup, since you've loaded the old key when you load the 
> FSImage. You'd only be lacking a DT master key on a fresh cluster, in which 
> case we could have it generate one at format time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to