[
https://issues.apache.org/jira/browse/HDFS-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Collins updated HDFS-2819:
------------------------------
Attachment: hdfs-2819-ammend.txt
Thanks for the review Suresh. Comments below and updated patch attached
(hdfs-2819-ammend.txt)
#1 Because it is the prefix for a key rather than a key itself (ie you can't
use it by itself to lookup anything). This prefix plus a suffix (namespace ID)
will result in a key that refers to a set of namesnodes. The naming is
consistent with other variables that use _PREFIX.
#2 "dfs.ha.namenodes" is the prefix for a given namservice, eg
"dfs.ha.namenodes.EXAMPLENAMESERVICE". This description already says "contains
a comma-separated list of namenodes", maybe you were thinking of another key?
#3 Yes, empty values are parsed as null. Note that a value with whitespace is
not, ie "<value> </value>" here would not be kosher.
#4 I added them per Todd's request above, disagree w his thinking?
#5 These values are used to set "ipc.client.connect.max.retries" and
"ipc.client.connect.max.retries.on.timeouts" respectively for the failover rpc
proxy. I updated the description with the rationale for the 0 default (failover
effectively means the clients do retry). These are marked "Expert only" because
we don't expect most users to modify them or need to understand them.
#6 The base time is 500ms and we don't wait on the first retry so the sequence
is 0, 1s, 2s, 4s, 8s, .. (up to 15 retries, the last base value caps at 8s,
though note that the 5th to 15th values, like the others, will vary by +/- 50%
each time, so could delay up to 12s). Make sense?
#7 Not sure I follow, do you have a specific suggestion? I marked these as
"Expert only" because we don't expect most users to modify or need to
understand them.
> Document new HA-related configs in hdfs-default.xml
> ---------------------------------------------------
>
> Key: HDFS-2819
> URL: https://issues.apache.org/jira/browse/HDFS-2819
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: documentation, ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Todd Lipcon
> Assignee: Eli Collins
> Attachments: hdfs-2819-ammend.txt, hdfs-2819.txt, hdfs-2819.txt,
> hdfs-2819.txt
>
>
> We've added a few configs, like shared edits dir, dfs.ha.namenodes, etc - we
> should probably add these to hdfs-default.xml so they get documented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
