[ https://issues.apache.org/jira/browse/HDFS-16616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shilun Fan updated HDFS-16616: ------------------------------ Component/s: hdfs-common Hadoop Flags: Reviewed Target Version/s: 3.4.0 Affects Version/s: 3.4.0 > Remove the use if Sets#newHashSet and Sets#newTreeSet > ------------------------------------------------------ > > Key: HDFS-16616 > URL: https://issues.apache.org/jira/browse/HDFS-16616 > Project: Hadoop HDFS > Issue Type: Task > Components: hdfs-common > Affects Versions: 3.4.0 > Reporter: Samrat Deb > Assignee: Samrat Deb > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > As part of removing guava dependencies HADOOP-17115, HADOOP-17721, > HADOOP-17722 and HADOOP-17720 are fixed, > Currently the code call util function to create HashSet and TreeSet in the > repo . These function calls dont have much importance as it is calling > internally new HashSet<> / new TreeSet<> from java.utils > This task is to clean up all the function calls to create sets which is > redundant > Before moving to java8 , sets were created using guava functions and API , > now since this is moved away and util code in the hadoop now looks like > 1. > public static <E extends Comparable> TreeSet<E> newTreeSet() { return new > TreeSet<E>(); > 2. > public static <E> HashSet<E> newHashSet() > { return new HashSet(); } > These interfaces dont do anything much just a extra layer of function call > please refer to the task > https://issues.apache.org/jira/browse/HADOOP-17726 > Can anyone review if this ticket add some value in the code. > Looking forward to some input/ thoughts . If not adding any value we can > close it and not move forward with changes ! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org