[ 
https://issues.apache.org/jira/browse/HDFS-17146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823945#comment-17823945
 ] 

ASF GitHub Bot commented on HDFS-17146:
---------------------------------------

zhtttylz commented on code in PR #6595:
URL: https://github.com/apache/hadoop/pull/6595#discussion_r1514181677


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java:
##########
@@ -1377,7 +1377,8 @@ public Boolean get() {
         }
         scanIntoList(out, outs);
         scanIntoList(err, errs);
-        return !outs.isEmpty() && outs.get(0).contains("finished");
+        return !outs.isEmpty() && outs.stream().filter(line ->
+            line.contains("finished")).count() == 2;

Review Comment:
   This test case is to refresh the configuration of two nodes in the cluster 
that are in the decommissioning state. It is necessary to wait for the 'finish' 
keyword of both nodes before the subsequent information verification becomes 
meaningful.





> Use the dfsadmin -reconfig command to initiate reconfiguration on all 
> decommissioning datanodes.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17146
>                 URL: https://issues.apache.org/jira/browse/HDFS-17146
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: dfsadmin, hdfs
>    Affects Versions: 3.4.0
>            Reporter: Hualong Zhang
>            Assignee: Hualong Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.1, 3.5.0
>
>
> If the *DFSAdmin* command could have the ability to perform bulk operations 
> across all decommissioned datanodes, that would be highly advantageous.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to