[
https://issues.apache.org/jira/browse/HDFS-17401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825264#comment-17825264
]
ASF GitHub Bot commented on HDFS-17401:
---------------------------------------
haiyang1987 commented on code in PR #6597:
URL: https://github.com/apache/hadoop/pull/6597#discussion_r1519563597
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -4359,9 +4348,15 @@ private void
chooseExcessRedundancyStriped(BlockCollection bc,
}
}
if (candidates.size() > 1) {
+ List<StorageType> internalExcessTypes = storagePolicy.chooseExcess(
+ (short) 1, DatanodeStorageInfo.toStorageTypes(candidates));
+ if (internalExcessTypes.isEmpty()) {
Review Comment:
About internalExcessTypes, could you explain which case will empty ? thanks~
> EC: Excess internal block may not be able to be deleted correctly when it's
> stored in fallback storage
> ------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17401
> URL: https://issues.apache.org/jira/browse/HDFS-17401
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.3.6
> Reporter: Ruinan Gu
> Assignee: Ruinan Gu
> Priority: Major
> Labels: pull-request-available
>
> Excess internal block can't be deleted correctly when it's stored in fallback
> storage.
> Simple case:
> EC-RS-6-3-1024k file is stored using ALL_SSD storage policy(SSD is default
> storage type and DISK is fallback storage type), if the block group is as
> follows
> [0(SSD), 0(SSD), 1(SSD), 2(SSD), 3(SSD), 4(SSD), 5(SSD), 6(SSD), 7(SSD),
> 8(DISK)]
> The are two index 0 internal block and one of them should be chosen to
> delete.But the current implement chooses the index 0 internal blocks as
> candidates but DISK as exess storage type.As a result, the exess storage
> type(DISK) can not correspond to the exess internal blocks' storage type(SSD)
> correctly, and the exess internal block can not be deleted correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
