[ https://issues.apache.org/jira/browse/HDFS-17388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831725#comment-17831725 ]
ASF GitHub Bot commented on HDFS-17388: --------------------------------------- ferhui commented on code in PR #6589: URL: https://github.com/apache/hadoop/pull/6589#discussion_r1542703171 ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java: ########## @@ -982,6 +982,11 @@ public final long computeFileSizeNotIncludingLastUcBlock() { * if includesLastUcBlock == false. * @return file size */ + // ComputeFileSize only needs the FSLock even through it involves block. Review Comment: can add new comments into the above comment scope? e.g. below 'Compute file size of the current file.' ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java: ########## @@ -1998,6 +1998,7 @@ FileStatus getAuditFileInfo(INodesInPath iip) if (inode.isFile()) { final INodeFile fileNode = inode.asFile(); + // Depends on status of the last block Review Comment: do you mean it needs to hold lock here? Can add more comments here. > [FGL] Client RPCs involving write process supports fine-grained lock > -------------------------------------------------------------------- > > Key: HDFS-17388 > URL: https://issues.apache.org/jira/browse/HDFS-17388 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: ZanderXu > Assignee: ZanderXu > Priority: Major > Labels: pull-request-available > > The client write process involves many client RPCs. > > This ticket is used to make these RPCs support fine-grained lock. > * mkdir > * create > * addBlock > * abandonBlock > * getAdditionalDatanode > * updateBlockForPipeline > * updatePipeline > * fsync > * complete > * rename > * rename2 > * append > * renewLease > * recoverLease > * delete > * createSymlink > * renewDelegationToken > * cancelDelegationToken -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org