[
https://issues.apache.org/jira/browse/HDFS-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832834#comment-17832834
]
ASF GitHub Bot commented on HDFS-17408:
---------------------------------------
ThinkerLei commented on PR #6653:
URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2029711670
> @ThinkerLei Thanks for your reply. So what you mean is: If src directory
does not have any storage policy set (that is, files under src use the default
storage policy, ALL_DISK for example) and dst is set to ALL_SSD, then after
renaming src to dst, the data blocks will be stored on the SSD. Do I understand
correctly?
The current logic is that if the block is not rebuilt, the data blocks will
not be stored on the SSD. I'm not quite clear on the rationale behind this
design. If necessary, we can open another issue to discuss it further.
> Reduce the number of quota calculations in FSDirRenameOp
> --------------------------------------------------------
>
> Key: HDFS-17408
> URL: https://issues.apache.org/jira/browse/HDFS-17408
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: lei w
> Assignee: lei w
> Priority: Major
> Labels: pull-request-available
>
> During the execution of the rename operation, we first calculate the quota
> for the source INode using verifyQuotaForRename, and at the same time, we
> calculate the quota for the target INode. Subsequently, in
> RenameOperation#removeSrc, RenameOperation#removeSrc4OldRename, and
> RenameOperation#addSourceToDestination, the quota for the source directory is
> calculated again. In exceptional cases, RenameOperation#restoreDst and
> RenameOperation#restoreSource will also perform quota calculations for the
> source and target directories. In fact, many of the quota calculations are
> redundant and unnecessary, so we should optimize them away.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
