[
https://issues.apache.org/jira/browse/HDFS-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834109#comment-17834109
]
ASF GitHub Bot commented on HDFS-17451:
---------------------------------------
KeeProMise commented on code in PR #6697:
URL: https://github.com/apache/hadoop/pull/6697#discussion_r1552627925
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##########
@@ -1089,13 +1089,7 @@ public DatanodeInfo[]
getDatanodeReport(DatanodeReportType type)
DatanodeInfo[] getCachedDatanodeReport(DatanodeReportType type)
throws IOException {
try {
- DatanodeInfo[] dns = this.dnCache.get(type);
- if (dns == null) {
- LOG.debug("Get null DN report from cache");
- dns = getCachedDatanodeReportImpl(type);
- this.dnCache.put(type, dns);
- }
- return dns;
+ return this.dnCache.get(type);
Review Comment:
@slfan1989 @ayushtkn Thanks for your review, this modification is just to
test whether spotbug will pass. Why do I still get a spotbugs exception after
deleting the relevant code?
> RBF: fix spotbugs for redundant nullcheck of dns.
> -------------------------------------------------
>
> Key: HDFS-17451
> URL: https://issues.apache.org/jira/browse/HDFS-17451
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jian Zhang
> Assignee: Jian Zhang
> Priority: Major
> Labels: pull-request-available
>
> h2. Dodgy code Warnings
> ||Code||Warning||
> |RCN|Redundant nullcheck of dns, which is known to be non-null in
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getCachedDatanodeReport(HdfsConstants$DatanodeReportType)|
> | |[Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for
> details)|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6655/8/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE]
> In class org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer
> In method
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getCachedDatanodeReport(HdfsConstants$DatanodeReportType)
> Value loaded from dns
> Return value of
> org.apache.hadoop.thirdparty.com.google.common.cache.LoadingCache.get(Object)
> of type Object
> Redundant null check at RouterRpcServer.java:[line 1093]|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
