[ https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836915#comment-17836915 ]
ASF GitHub Bot commented on HDFS-17465: --------------------------------------- KeeProMise commented on code in PR #6727: URL: https://github.com/apache/hadoop/pull/6727#discussion_r1564577262 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java: ########## @@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) { public void releasePermit(String nsId) { if (contains(nsId)) { super.releasePermit(nsId); + } else { + super.releasePermit(DEFAULT_NS); } Review Comment: Personal opinion, whether it can be written like this. ```java if (contains(nsId)) { super.releasePermit(nsId); return; } super.releasePermit(DEFAULT_NS); ``` > RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: > Maximum permit count exceeded” > ----------------------------------------------------------------------------------------------------------- > > Key: HDFS-17465 > URL: https://issues.apache.org/jira/browse/HDFS-17465 > Project: Hadoop HDFS > Issue Type: Bug > Components: rbf > Reporter: Xiping Zhang > Assignee: Xiping Zhang > Priority: Blocker > Labels: pull-request-available > Attachments: image-2024-04-14-15-39-59-531.png, > image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png > > > !image-2024-04-14-15-39-59-531.png! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org