[ 
https://issues.apache.org/jira/browse/HDFS-17476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838301#comment-17838301
 ] 

ASF GitHub Bot commented on HDFS-17476:
---------------------------------------

KeeProMise opened a new pull request, #6747:
URL: https://github.com/apache/hadoop/pull/6747

   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   seeAlse : https://issues.apache.org/jira/browse/HDFS-17476
   In the code GlobalStateIdContext#receiveRequestState(), if clientStateId is 
a small negative number, clientStateId-serverStateId may be greater than 
   
   (ESTIMATED_TRANSACTIONS_PER_SECOND due to overflow
                     * TimeUnit.MILLISECONDS.toSeconds(clientWaitTime)
                     * ESTIMATED_SERVER_TIME_MULTIPLIER),
   
   resulting in false positives that Observer Node is too far behind.
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> fix: False positive "Observer Node is too far behind" due to long overflow.
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-17476
>                 URL: https://issues.apache.org/jira/browse/HDFS-17476
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Jian Zhang
>            Assignee: Jian Zhang
>            Priority: Critical
>         Attachments: HDFS-17476.patch
>
>
> In the code GlobalStateIdContext#receiveRequestState(), if clientStateId is a 
> small negative number, clientStateId-serverStateId may be greater than 
> (ESTIMATED_TRANSACTIONS_PER_SECOND due to overflow
>                   * TimeUnit.MILLISECONDS.toSeconds(clientWaitTime)
>                   * ESTIMATED_SERVER_TIME_MULTIPLIER),
> resulting in false positives that Observer Node is too far behind.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to