[ https://issues.apache.org/jira/browse/HDFS-17484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839911#comment-17839911 ]
ASF GitHub Bot commented on HDFS-17484: --------------------------------------- hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2071256591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 01s | | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 00s | | spotbugs executables are not available. | | +0 :ok: | codespell | 0m 00s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 00s | | detect-secrets was not available. | | +0 :ok: | xmllint | 0m 00s | | xmllint was not available. | | +1 :green_heart: | @author | 0m 00s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 00s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 89m 50s | | trunk passed | | +1 :green_heart: | compile | 5m 55s | | trunk passed | | +1 :green_heart: | checkstyle | 4m 58s | | trunk passed | | +1 :green_heart: | mvnsite | 6m 30s | | trunk passed | | +1 :green_heart: | javadoc | 5m 47s | | trunk passed | | +1 :green_heart: | shadedclient | 148m 26s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 49s | | the patch passed | | +1 :green_heart: | compile | 3m 26s | | the patch passed | | +1 :green_heart: | javac | 3m 26s | | the patch passed | | -1 :x: | blanks | 0m 00s | [/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6758/1/artifact/out/blanks-eol.txt) | The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | checkstyle | 2m 19s | | the patch passed | | +1 :green_heart: | mvnsite | 4m 03s | | the patch passed | | +1 :green_heart: | javadoc | 3m 27s | | the patch passed | | +1 :green_heart: | shadedclient | 158m 13s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 29s | | The patch does not generate ASF License warnings. | | | | 423m 09s | | | | Subsystem | Report/Notes | |----------:|:-------------| | GITHUB PR | https://github.com/apache/hadoop/pull/6758 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint | | uname | MINGW64_NT-10.0-17763 be352c545e0b 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys | | Build tool | maven | | Personality | /c/hadoop/dev-support/bin/hadoop.sh | | git revision | trunk / b01d3bcf66844d7f7f66c04a496d8dcc39cddae6 | | Default Java | Azul Systems, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6758/1/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6758/1/console | | versions | git=2.44.0.windows.1 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when > they are not busy actually > ----------------------------------------------------------------------------------------------------- > > Key: HDFS-17484 > URL: https://issues.apache.org/jira/browse/HDFS-17484 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Affects Versions: 3.4.0 > Reporter: farmmamba > Assignee: farmmamba > Priority: Minor > Labels: pull-request-available > > Currently, we have `dfs.namenode.redundancy.considerLoad` equals true by > default, and > dfs.namenode.redundancy.considerLoad.factor equals 2.0 by default. > Think about below situation. when we are doing stress test, we may deploy > hdfs client onto the datanode. So, this hdfs client will prefer to write to > its local datanode and increase this machine's load. Suppose we have 3 > datanodes, the load of them are as below: 5.0, 0.2, 0.3. > > The load equals to 5.0 will be excluded when choose datanodes for a block. > But actually, it is not slow node when load equals to 5.0 for a machine with > 80 cpu cores. > > So, we should better add a new configuration entry : > `dfs.namenode.redundancy.considerLoad.minLoad` to indicate the mininum factor > we will make considerLoad take effect. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org