[
https://issues.apache.org/jira/browse/HDFS-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840758#comment-17840758
]
ASF GitHub Bot commented on HDFS-17382:
---------------------------------------
hadoop-yetus commented on PR #6584:
URL: https://github.com/apache/hadoop/pull/6584#issuecomment-2076934071
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 00s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 01s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 01s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 01s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 00s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 00s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ branch-3.4 Compile Tests _ |
| +0 :ok: | mvndep | 1m 55s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 87m 15s | | branch-3.4 passed |
| +1 :green_heart: | compile | 38m 06s | | branch-3.4 passed |
| +1 :green_heart: | mvnsite | 14m 54s | | branch-3.4 passed |
| +1 :green_heart: | javadoc | 13m 49s | | branch-3.4 passed |
| +1 :green_heart: | shadedclient | 284m 31s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 2m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 22m 44s | | the patch passed |
| +1 :green_heart: | compile | 35m 51s | | the patch passed |
| +1 :green_heart: | javac | 35m 51s | | the patch passed |
| +1 :green_heart: | blanks | 0m 00s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 14m 44s | | the patch passed |
| +1 :green_heart: | javadoc | 13m 58s | | the patch passed |
| +1 :green_heart: | shadedclient | 163m 36s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 34s | | hadoop-project in the patch
passed. |
| -1 :x: | unit | 289m 01s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6584/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | unit | 6m 00s | | hadoop-client-minicluster in
the patch passed. |
| -1 :x: | asflicense | 8m 37s |
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6584/1/artifact/out/results-asflicense.txt)
| The patch generated 2 ASF License warnings. |
| | | 835m 57s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.cli.TestCacheAdminCLI |
| | hadoop.cli.TestXAttrCLI |
| | hadoop.fs.viewfs.TestViewFileSystemAtHdfsRoot |
| | hadoop.fs.viewfs.TestViewFileSystemHdfs |
| | hadoop.fs.viewfs.TestViewFileSystemLinkFallback |
| | hadoop.fs.viewfs.TestViewFileSystemLinkMergeSlash |
| | hadoop.fs.viewfs.TestViewFileSystemLinkRegex |
| |
hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract |
| | hadoop.fs.viewfs.TestViewFsAtHdfsRoot |
| | hadoop.fs.viewfs.TestViewFsHdfs |
| | hadoop.fs.viewfs.TestViewFsLinkFallback |
| | hadoop.hdfs.protocol.TestBlockListAsLongs |
| | hadoop.hdfs.qjournal.server.TestJournalNode |
| | hadoop.hdfs.qjournal.server.TestJournalNodeMXBean |
| | hadoop.hdfs.qjournal.server.TestJournalNodeSync |
| | hadoop.hdfs.server.aliasmap.TestSecureAliasMap |
| | hadoop.hdfs.server.blockmanagement.TestBlockReportLease |
| | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithShortCircuitRead |
| |
hadoop.hdfs.server.common.blockaliasmap.impl.TestInMemoryLevelDBAliasMapClient |
| |
hadoop.hdfs.server.common.blockaliasmap.impl.TestLevelDBFileRegionAliasMap |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetCache |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistFiles |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestProvidedImpl |
| | hadoop.hdfs.server.datanode.TestBlockPoolSliceStorage |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| | hadoop.hdfs.server.datanode.TestDataNodeLifeline |
| | hadoop.hdfs.server.datanode.TestDataNodeMetrics |
| | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure |
| | hadoop.hdfs.server.datanode.TestDirectoryScanner |
| | hadoop.hdfs.server.datanode.TestLargeBlockReport |
| | hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand |
| | hadoop.hdfs.server.diskbalancer.TestDiskBalancerRPC |
| | hadoop.hdfs.server.diskbalancer.TestDiskBalancerWithMockMover |
| | hadoop.hdfs.server.diskbalancer.TestPlanner |
| | hadoop.hdfs.server.mover.TestMover |
| | hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap |
| | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA |
| | hadoop.hdfs.server.namenode.ha.TestHAAppend |
| | hadoop.hdfs.server.namenode.ha.TestHAMetrics |
| | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
| | hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics |
| | hadoop.hdfs.server.namenode.snapshot.TestOrderedSnapshotDeletionGc |
| | hadoop.hdfs.server.namenode.TestAuditLoggerWithCommands |
| | hadoop.hdfs.server.namenode.TestAuditLogs |
| | hadoop.hdfs.server.namenode.TestCacheDirectives |
| | hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS |
| | hadoop.hdfs.server.namenode.TestEditLog |
| | hadoop.hdfs.server.namenode.TestFsck |
| | hadoop.hdfs.server.namenode.TestFSImage |
| | hadoop.hdfs.server.namenode.TestFSNamesystemLockReport |
| | hadoop.hdfs.server.namenode.TestHDFSConcat |
| | hadoop.hdfs.server.namenode.TestNameNodeMXBean |
| | hadoop.hdfs.server.namenode.TestNameNodeReconfigure |
| | hadoop.hdfs.server.namenode.TestNamenodeRetryCache |
| | hadoop.hdfs.server.namenode.TestNetworkTopologyServlet |
| | hadoop.hdfs.server.namenode.TestNNStorageRetentionManager |
| | hadoop.hdfs.server.namenode.TestProtectedDirectories |
| | hadoop.hdfs.server.namenode.TestReconstructStripedBlocks |
| | hadoop.hdfs.server.namenode.TestSaveNamespace |
| | hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs |
| | hadoop.hdfs.TestDFSShell |
| | hadoop.hdfs.TestDFSUpgradeFromImage |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.TestErasureCodingExerciseAPIs |
| | hadoop.hdfs.TestFetchImage |
| | hadoop.hdfs.TestGetBlocks |
| | hadoop.hdfs.TestQuota |
| | hadoop.hdfs.TestSecureEncryptionZoneWithKMS |
| | hadoop.hdfs.TestTrashWithSecureEncryptionZones |
| | hadoop.hdfs.TestViewDistributedFileSystem |
| | hadoop.hdfs.TestViewDistributedFileSystemContract |
| | hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks |
| | hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer |
| | hadoop.hdfs.tools.TestDebugAdmin |
| | hadoop.hdfs.tools.TestDFSAdmin |
| | hadoop.hdfs.tools.TestDFSAdminWithHA |
| | hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithFSCommands |
| | hadoop.hdfs.tools.TestViewFSStoragePolicyCommands |
| | hadoop.hdfs.web.TestWebHDFS |
| | hadoop.hdfs.web.TestWebHdfsTokens |
| | hadoop.hdfs.web.TestWebHdfsUrl |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/6584 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | MINGW64_NT-10.0-17763 1d98a7c206b0 3.4.10-87d57229.x86_64
2024-02-14 20:17 UTC x86_64 Msys |
| Build tool | maven |
| Personality | /c/hadoop/dev-support/bin/hadoop.sh |
| git revision | branch-3.4 / 7c60bb5a2d3b3cd91a34be2b0b19c5d49bcfc2f6 |
| Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6584/1/testReport/
|
| modules | C: hadoop-project hadoop-hdfs-project/hadoop-hdfs
hadoop-client-modules/hadoop-client-minicluster U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6584/1/console
|
| versions | git=2.44.0.windows.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Add Apache Log4j Extras Library to Hadoop 3.3 for Enhanced Log Rolling
> Capabilities
> -----------------------------------------------------------------------------------
>
> Key: HDFS-17382
> URL: https://issues.apache.org/jira/browse/HDFS-17382
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: woosuk.ro
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2024-02-25-00-46-08-841.png
>
>
> In the current Hadoop 3.4 version, the system relies on Log4j 1.x for logging
> purposes. This dependency limits the logging functionality, especially when
> it comes to rolling log files such as 'hdfs-audit.log'. Rolling log files is
> crucial for managing log size and ensuring logs are rotated out over time to
> prevent excessive disk space usage. However, the Log4j 1.x version integrated
> within Hadoop lacks the necessary capabilities to efficiently handle log
> rolling.
> This library extends logging capabilities, including more flexible and
> configurable log rolling features. By deploying this library, we can enable
> advanced rolling strategies such as time-based rolling, size-based rolling,
> and compression of rolled logs, which are not supported by the default Log4j
> 1.x setup in Hadoop.
> The integration of Apache Log4j Extras into Hadoop will significantly improve
> log management by allowing for more sophisticated and configurable log
> rotation policies. This enhancement is particularly important for maintaining
> system performance and reliability, as well as for compliance with log
> retention policies.
> Although there are plans to upgrade to Log4j 2 in the forthcoming Hadoop 3.5
> version, which will inherently solve these issues by providing enhanced
> logging features, there is an immediate need to enable advanced log rolling
> capabilities in the current and previous versions of Hadoop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
