[ https://issues.apache.org/jira/browse/HDFS-17305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841375#comment-17841375 ]
ASF GitHub Bot commented on HDFS-17305: --------------------------------------- hadoop-yetus commented on PR #6393: URL: https://github.com/apache/hadoop/pull/6393#issuecomment-2080203909 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 01s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 01s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 01s | | detect-secrets was not available. | | +0 :ok: | markdownlint | 0m 01s | | markdownlint was not available. | | +0 :ok: | spotbugs | 0m 01s | | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 00s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 00s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 2m 24s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 93m 56s | | trunk passed | | +1 :green_heart: | compile | 42m 36s | | trunk passed | | +1 :green_heart: | checkstyle | 6m 25s | | trunk passed | | -1 :x: | mvnsite | 4m 44s | [/branch-mvnsite-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6393/1/artifact/out/branch-mvnsite-hadoop-common-project_hadoop-common.txt) | hadoop-common in trunk failed. | | +1 :green_heart: | javadoc | 11m 15s | | trunk passed | | +1 :green_heart: | shadedclient | 201m 15s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 2m 32s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 47s | | the patch passed | | +1 :green_heart: | compile | 39m 14s | | the patch passed | | +1 :green_heart: | javac | 39m 14s | | the patch passed | | +1 :green_heart: | blanks | 0m 01s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 6m 21s | | the patch passed | | -1 :x: | mvnsite | 4m 39s | [/patch-mvnsite-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6393/1/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch failed. | | +1 :green_heart: | javadoc | 11m 33s | | the patch passed | | +1 :green_heart: | shadedclient | 179m 44s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 58s | | The patch does not generate ASF License warnings. | | | | 583m 40s | | | | Subsystem | Report/Notes | |----------:|:-------------| | GITHUB PR | https://github.com/apache/hadoop/pull/6393 | | Optional Tests | dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle | | uname | MINGW64_NT-10.0-17763 7f59f0d70d63 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys | | Build tool | maven | | Personality | /c/hadoop/dev-support/bin/hadoop.sh | | git revision | trunk / cce347e407784e0ee537933dfcb65cf0ed4cf1fb | | Default Java | Azul Systems, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6393/1/testReport/ | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6393/1/console | | versions | git=2.44.0.windows.1 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Add avoid datanode reason count related metrics to namenode. > ------------------------------------------------------------ > > Key: HDFS-17305 > URL: https://issues.apache.org/jira/browse/HDFS-17305 > Project: Hadoop HDFS > Issue Type: New Feature > Reporter: Zhaobo Huang > Assignee: Zhaobo Huang > Priority: Minor > Labels: pull-request-available > > Now, there are slownode and load avoidance functions, mainly implemented in > theĀ BlockPlacementPolicyDefault class. > 1. After triggering the exclusion condition, some logs will be printed on nn, > which can be used to troubleshoot anomalies in nn by checking the logs, the > code is as follows: > {code:java} > ... > if (!node.isInService()) { > logNodeIsNotChosen(node, NodeNotChosenReason.NOT_IN_SERVICE); > return false; > } > if (avoidStaleNodes) { > if (node.isStale(this.staleInterval)) { > logNodeIsNotChosen(node, NodeNotChosenReason.NODE_STALE); > return false; > } > } > ...{code} > 2. If the exclusion condition is triggered, we can record it through metrics > and count the total number of exclusions. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org