[
https://issues.apache.org/jira/browse/HDFS-17518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846051#comment-17846051
]
ASF GitHub Bot commented on HDFS-17518:
---------------------------------------
vinayakumarb commented on code in PR #6809:
URL: https://github.com/apache/hadoop/pull/6809#discussion_r1599005240
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java:
##########
@@ -626,7 +626,8 @@ private synchronized boolean checkLeases(Collection<Lease>
leasesToCheck) {
}
}
// If a lease recovery happened, we need to sync later.
Review Comment:
On the other hand, if we see the complete logic of `internalReleaseLease()`
we need to call logSync() always.
There are two possibilities overall.
1. File gets closed.
2. lease recovery gets initiated with reassign of lease.
In both of above cases, there will be edit txn logged. So need to call
logSync().
> In the lease monitor, if a file is closed, we should sync the editslog
> ----------------------------------------------------------------------
>
> Key: HDFS-17518
> URL: https://issues.apache.org/jira/browse/HDFS-17518
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: lei w
> Assignee: lei w
> Priority: Minor
> Labels: pull-request-available
>
> In the lease monitor, if a file is closed, method checklease will return
> true, and then the edits log will not be sync. In my opinion, we should sync
> the edits log to avoid not synchronizing the state to the standby NameNode
> for a long time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
