[
https://issues.apache.org/jira/browse/HDFS-17529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848038#comment-17848038
]
ASF GitHub Bot commented on HDFS-17529:
---------------------------------------
ZanderXu commented on code in PR #6833:
URL: https://github.com/apache/hadoop/pull/6833#discussion_r1607542930
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreRecordOperations.java:
##########
@@ -127,6 +128,17 @@ <T extends BaseRecord> StateStoreOperationResult putAll(
@AtMostOnce
<T extends BaseRecord> boolean remove(T record) throws IOException;
+ /**
+ * Remove multiple records.
+ *
+ * @param <T> Record class of the records.
+ * @param records Records to be removed.
+ * @return Map of record -> boolean indicating any entries being deleted by
this record.
Review Comment:
`Map of record -> boolean indicating if the record has being removed
successfully`
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/StateStoreRecordOperations.java:
##########
@@ -152,4 +164,17 @@ <T extends BaseRecord> StateStoreOperationResult putAll(
<T extends BaseRecord> int remove(Class<T> clazz, Query<T> query)
throws IOException;
+ /**
+ * Remove all records of a specific class that match any query in a list of
queries.
+ * Requires the getAll implementation to fetch fresh records on each call.
+ *
+ * @param clazz The class to match the records with.
+ * @param queries Queries (logical OR) to filter what to remove.
+ * @param <T> Record class of the records.
+ * @return Map of query to number of records deleted by that query.
Review Comment:
`Map of query to number of records removed by that query.`
> Improve router state store cache entry deletion
> -----------------------------------------------
>
> Key: HDFS-17529
> URL: https://issues.apache.org/jira/browse/HDFS-17529
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs, rbf
> Reporter: Felix N
> Assignee: Felix N
> Priority: Major
> Labels: pull-request-available
>
> Current implementation for router state store update is quite inefficient, so
> much that when routers are removed and a lot of NameNodeMembership records
> are deleted in a short burst, the deletions triggered a router safemode in
> our cluster and caused a lot of troubles.
> This ticket aims to improve the deletion process for ZK state store
> implementation.
> See HDFS-17532 for the other half of this improvement
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
