[ https://issues.apache.org/jira/browse/HDFS-17544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852997#comment-17852997 ]
ASF GitHub Bot commented on HDFS-17544: --------------------------------------- KeeProMise commented on PR #6870: URL: https://github.com/apache/hadoop/pull/6870#issuecomment-2153741838 > @KeeProMise Hi, sir. The code in this PR contains [HDFS-17543](https://issues.apache.org/jira/browse/HDFS-17543)'s change. Can we seperate them for better reviewing. @hfutatzhanghb Hi, It does include HDFS-17543. The main reason is that this PR needs to use AsyncUtil of HDFS-17543. We should first review and merge HDFS-17543 and then review this PR. Before HDFS-17543 is merged, this PR is only used as an example of subsequent use of AsyncUtil. > [ARR] The router client rpc protocol supports asynchrony. > --------------------------------------------------------- > > Key: HDFS-17544 > URL: https://issues.apache.org/jira/browse/HDFS-17544 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Jian Zhang > Assignee: Jian Zhang > Priority: Major > Labels: pull-request-available > > *Describe* > In order not to affect other modules, when implementing router asynchronous > client rpc protocolPB, it mainly extends the original protocolPB; The > implemented protocolPB is as follows: > *RouterClientProtocolTranslatorPB* extends ClientNamenodeProtocolTranslatorPB > *RouterGetUserMappingsProtocolTranslatorPB* extends > GetUserMappingsProtocolClientSideTranslatorPB > *RouterNamenodeProtocolTranslatorPB* extends NamenodeProtocolTranslatorPB > *RouterRefreshUserMappingsProtocolTranslatorPB* extends > RefreshUserMappingsProtocolClientSideTranslatorPB > Then let the router's *ConnectionPool* use the aforementioned protocolPB > In the implementation of asynchronous Rpc.client, the main methods used > include HADOOP-13226, HDFS-10224, etc > {*}AsyncRpcProtocolPBUtil{*}: Make the implementation of asynchronous rpc > protocol more concise and clear. > > *Test* > I modified RouterRpcClient to use asynchronous client protocolPB for testing. > > {*}Note{*}: For a discussion on the AsyncUtil introduced by this PR, please > refer to it HDFS-17543 This PR requires the use of this tool; Please ignore > the modification of RouterRpcClient, just for the convenience of testing the > asynchronous client mentioned above. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org