[
https://issues.apache.org/jira/browse/HDFS-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205671#comment-13205671
]
Hudson commented on HDFS-2931:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #524 (See
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/524/])
svn merge -c 1242891 from trunk for HDFS-2931.
szetszwo :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242892
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockVolumeChoosingPolicy.java
> Switch the DataNode's BlockVolumeChoosingPolicy to be a private-audience
> interface
> ----------------------------------------------------------------------------------
>
> Key: HDFS-2931
> URL: https://issues.apache.org/jira/browse/HDFS-2931
> Project: Hadoop HDFS
> Issue Type: Task
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: api
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HDFS-2931.patch
>
>
> From Nicholas, at the tail of HDFS-1120:
> {quote}
> However, if we annotate it as public, all the classes associated with them
> should also be annotated as public. Also, whenever we change the interface or
> any of the associated classes, it is an incompatible change.
> In our case, BlockVolumeChoosingPolicy uses FSVolumeInterface, which is a
> part of FSDatasetInterface. In FSDatasetInterface, there are many classes
> should not be exposed. One way to solve it is to make FSVolumeInterface
> independent of FSDatasetInterface. However, FSVolumeInterface is not yet a
> well-designed interface for the public.
> For these reasons, it is justified to annotate it as private, the same as
> BlockPlacementPolicy.
> {quote}
> We should switch BlockVolumeChoosingPolicy to for a private audience.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
