[
https://issues.apache.org/jira/browse/HDFS-17544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868526#comment-17868526
]
ASF GitHub Bot commented on HDFS-17544:
---------------------------------------
hadoop-yetus commented on PR #6870:
URL: https://github.com/apache/hadoop/pull/6870#issuecomment-2249272166
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | patch | 0m 20s | |
https://github.com/apache/hadoop/pull/6870 does not apply to HDFS-17531. Rebase
required? Wrong Branch? See
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
|
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/6870 |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6870/13/console |
| versions | git=2.34.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> [ARR] The router client rpc protocol PB supports asynchrony.
> ------------------------------------------------------------
>
> Key: HDFS-17544
> URL: https://issues.apache.org/jira/browse/HDFS-17544
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jian Zhang
> Assignee: Jian Zhang
> Priority: Major
> Labels: pull-request-available
>
> *Describe*
> In order not to affect other modules, when implementing router asynchronous
> client rpc protocolPB, it mainly extends the original protocolPB; The
> implemented protocolPB is as follows:
> *RouterClientProtocolTranslatorPB* extends ClientNamenodeProtocolTranslatorPB
> *RouterGetUserMappingsProtocolTranslatorPB* extends
> GetUserMappingsProtocolClientSideTranslatorPB
> *RouterNamenodeProtocolTranslatorPB* extends NamenodeProtocolTranslatorPB
> *RouterRefreshUserMappingsProtocolTranslatorPB* extends
> RefreshUserMappingsProtocolClientSideTranslatorPB
> Then let the router's *ConnectionPool* use the aforementioned protocolPB
> In the implementation of asynchronous Rpc.client, the main methods used
> include HADOOP-13226, HDFS-10224, etc
> {*}AsyncRpcProtocolPBUtil{*}: Make the implementation of asynchronous rpc
> protocol more concise and clear.
>
> *Test*
> new UTs:
> 1.TestAsyncRpcProtocolPBUtil
> 2.TestRouterClientSideTranslatorPB
>
> {*}Note{*}: For a discussion on the AsyncUtil introduced by this PR, please
> refer to it HDFS-17543 This PR requires the use of this tool; Please ignore
> the modification of RouterRpcClient, just for the convenience of testing the
> asynchronous client mentioned above. This pull request is a follow-up to
> HDFS-17552, and thus depends on the code from HDFS-17552. Before HDFS-17552
> is merged, you can refer to this pull request to understand how to use the
> asynchronous IPC client in HDFS-17552.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
