[ https://issues.apache.org/jira/browse/HDFS-17569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868903#comment-17868903 ]
ASF GitHub Bot commented on HDFS-17569: --------------------------------------- hadoop-yetus commented on PR #6924: URL: https://github.com/apache/hadoop/pull/6924#issuecomment-2252322039 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 25s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 5 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 36m 18s | | trunk passed | | +1 :green_heart: | compile | 0m 42s | | trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 | | +1 :green_heart: | compile | 0m 42s | | trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08 | | +1 :green_heart: | checkstyle | 0m 42s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 45s | | trunk passed | | +1 :green_heart: | javadoc | 0m 43s | | trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 | | +1 :green_heart: | javadoc | 1m 13s | | trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08 | | +1 :green_heart: | spotbugs | 1m 59s | | trunk passed | | +1 :green_heart: | shadedclient | 26m 8s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 37s | | the patch passed | | +1 :green_heart: | compile | 0m 41s | | the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 | | +1 :green_heart: | javac | 0m 41s | | the patch passed | | +1 :green_heart: | compile | 0m 35s | | the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08 | | +1 :green_heart: | javac | 0m 35s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 0m 33s | [/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6924/15/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs-project/hadoop-hdfs: The patch generated 18 new + 222 unchanged - 0 fixed = 240 total (was 222) | | +1 :green_heart: | mvnsite | 0m 44s | | the patch passed | | +1 :green_heart: | javadoc | 0m 31s | | the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 | | +1 :green_heart: | javadoc | 1m 10s | | the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08 | | +1 :green_heart: | spotbugs | 1m 55s | | the patch passed | | +1 :green_heart: | shadedclient | 25m 54s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | -1 :x: | unit | 207m 37s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6924/15/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. | | -1 :x: | asflicense | 0m 31s | [/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6924/15/artifact/out/results-asflicense.txt) | The patch generated 1 ASF License warnings. | | | | 309m 39s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy | | | hadoop.hdfs.server.namenode.TestNamenodeCapacityReport | | | hadoop.hdfs.TestErasureCodingPolicies | | | hadoop.hdfs.server.namenode.TestRefreshBlockPlacementPolicy | | | hadoop.hdfs.TestErasureCodingMultipleRacks | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6924/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6924 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux a20b271d1e83 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 784f5e387a79de98f8e3614daa405abcbd32a19a | | Default Java | Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6924/15/testReport/ | | Max. process+thread count | 3950 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6924/15/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Setup Effective Work Number when Generating Block Reconstruction Work > --------------------------------------------------------------------- > > Key: HDFS-17569 > URL: https://issues.apache.org/jira/browse/HDFS-17569 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: wuchang > Priority: Major > Labels: pull-request-available > > h1. Description of PR > The *{{RedundancyMonitor}}* is a Daemon which will sleep *3s* for each tick. > In {{{}*computeBlockReconstructionWork(int blocksToProcess)*{}}}, it will use > *{{chooseLowRedundancyBlocks()}}* to firstly find the candidate > low-redundancy blocks(the max number is parameter *{{blocksToProcess}}* ) and > then use {{*computeReconstructionWorkForBlocks()*}} to compute the > reconstruction. > But in some cases, the candidate low-redundancy blocks will be skipped for > reconstruction scheduling for different reasons(source unavailable, target > not found, validation failed, etc), but some other low-priority blocks which > is able for reconstruction has to wait for many other rounds before scheduled. > h1. How it happened in my case > In my case, I have a 7 datanodes cluster({{{}a1 ~ a5{}}}, {{{}b1 ~ b2{}}})) > and I want to add a new datanode {{b3}} to it and at the same time > decommission {{{}a1 ~ a5{}}}. > I find that the decommission takes one week to finish(less than 10000 blocks > on each node). and I find below logs: > {code:java} > 2024-07-02 03:14:48,166 DEBUG > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager: Block > blk_1073806598_65774 cannot be reconstructed from any node > 2024-07-02 03:14:48,166 DEBUG > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager: Block > blk_1073806599_65775 cannot be reconstructed from any node > 2024-07-02 03:14:48,166 DEBUG > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager: Block > blk_1073806600_65776 cannot be reconstructed from any node > 2024-07-02 03:14:48,166 DEBUG > org.apache.hadoop.hdfs.server.blockmanagement.BlockManager: Block > blk_1073806603_65779 cannot be reconstructed from any node{code} > These blocks cannot be scheduled for reconstruction, but used up the quota > ({{{}blocksToProcess{}}}) in each tick, delayed the replicas on the > decommissioning nodes to be scheduled for reconstruction, thus the > decommission becomes very long-tail. > > h1. My Solution: > So my solution is, when we meet the low-redundancy blocks to be skipped for > reconstruction, move fast-forward inside current tick to check other > low-redundancy blocks to schedule reconstruction for them. > Of course, the total number of blocks scheduled for reconstruction > successfully will be restricted by parameter {*}blocksToProcess{*}. > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org