[
https://issues.apache.org/jira/browse/HDFS-17556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876752#comment-17876752
]
ASF GitHub Bot commented on HDFS-17556:
---------------------------------------
zhengchenyu commented on PR #6896:
URL: https://github.com/apache/hadoop/pull/6896#issuecomment-2310436077
@lfxy
you does not catch me. I said the same thing as you said. My (1) is just
your (1) -> (2), My (2) is just your (4) -> (5).
I suggest checking in (4)->(5).
Although we filter out timed out blocks in (1) -> (2), we still need to add
these block in (4) -> (5). We can do the check in (4) -> (5). Generally
speaking, the verification cost in (4) -> (5) is lower, because there are fewer
blocks to check. And there is no need to change timedOutItems from List to Set.
> Avoid adding block to neededReconstruction repeatedly in decommission
> ---------------------------------------------------------------------
>
> Key: HDFS-17556
> URL: https://issues.apache.org/jira/browse/HDFS-17556
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namanode
> Affects Versions: 3.5.0
> Reporter: caozhiqiang
> Assignee: caozhiqiang
> Priority: Major
> Labels: pull-request-available
>
> In decommission and maintenance process, before added to
> BlockManager::neededReconstruction block will be check if it has been added.
> The check contains if block is in BlockManager::neededReconstruction or in
> PendingReconstructionBlocks::pendingReconstructions as below code.
> But it also need to check if it is in
> PendingReconstructionBlocks::timedOutItems. Or else
> DatanodeAdminDefaultMonitor will add block to
> BlockManager::neededReconstruction repeatedly if block time out in
> PendingReconstructionBlocks::pendingReconstructions.
>
> {code:java}
> if (!blockManager.neededReconstruction.contains(block) &&
> blockManager.pendingReconstruction.getNumReplicas(block) == 0 &&
> blockManager.isPopulatingReplQueues()) {
> // Process these blocks only when active NN is out of safe mode.
> blockManager.neededReconstruction.add(block,
> liveReplicas, num.readOnlyReplicas(),
> num.outOfServiceReplicas(),
> blockManager.getExpectedRedundancyNum(block));
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
