[
https://issues.apache.org/jira/browse/HDFS-17642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892229#comment-17892229
]
ASF GitHub Bot commented on HDFS-17642:
---------------------------------------
aQuigs commented on code in PR #7127:
URL: https://github.com/apache/hadoop/pull/7127#discussion_r1813174162
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java:
##########
@@ -1078,6 +1116,10 @@ static BalancerParameters parse(String[] args) {
}
Preconditions.checkArgument(excludedNodes == null || includedNodes
== null,
"-exclude and -include options cannot be specified together.");
+ Preconditions.checkArgument(excludedSourceNodes == null ||
sourceNodes == null,
+ "-exclude and -include options cannot be specified together.");
+ Preconditions.checkArgument(excludedTargetNodes == null ||
targetNodes == null,
+ "-exclude and -include options cannot be specified together.");
Review Comment:
nit: fixup these error messages too for the proper arg name
> Support specifying Datanodes to exclude for balancing at source/target
> granularity
> ----------------------------------------------------------------------------------
>
> Key: HDFS-17642
> URL: https://issues.apache.org/jira/browse/HDFS-17642
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover
> Reporter: Joseph Dell'Aringa
> Assignee: Joseph Dell'Aringa
> Priority: Major
> Labels: pull-request-available
>
> In some cases it can be useful to exclude a list of datanodes from being
> selected as a target but remaining an option for a source and vice-versa.
> The fix for this ticket will add an additional exclude list for source and
> target datanodes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
